Desk Bell #5330
Desk Bell #5330
Conversation
github-actions
bot
added
Sprites
|
Please for the love of all that is hearing, increase the cooldown to AT LEAST 3 seconds. |
|
Have made further map changes @Nanu308 added a couple more bells to various areas at request of the sprite artist. |
There was a problem hiding this comment.
It's cute, but the bell is way too high off the stand and the stand is also way too big. You only really need a pixel of locomotion for the animation to be visible from a distance, and can achieve that even with a small stand. See below for my recommendation.
Also note: avoid using diagonals that zig-zag like this. Try using an intermediate color to break up the line instead, or avoid zig-zags entirely and use straight diagonals.
|
@nauticall thanks for the review, I will pass this onto the spriter and get them to adjust the sprite accordingly. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> Revives #5330. Cooldown adjusted because I know how much of a headache a 1 second cooldown would give. Credit: Modified code and desk_bell.ogg from [Paradise SS13](https://github.com/ParadiseSS13/Paradise) Sprite from Kat 'APC' Smith - darklordcabbage on discord. I just modified it a bit according to nauticall's review on the past PR. Animated sprite from Thwomp. Also modified. Birdtalon for the code. <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game Grab req's attention without having to point at their floor. Grab the offscreen WJ's attention. Immersion? # Testing Photographs and Procedure <!-- Include any screenshots/videos/debugging steps of the modified code functioning successfully, ideally including edge cases. --> <!-- !! If you are modifying sprites, you **must** include one or more in-game screenshots or videos of the new sprites. !! --> <details> <summary>Screenshots & Videos</summary>   </details> # Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly label your changes in the changelog. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> <!-- If you add a name after the ':cl', that name will be used in the changelog. You must add your CKEY after the CL if your GitHub name doesn't match. Maintainers freely reserve the right to remove and add tags should they deem it appropriate. --> :cl: Birdtalon, Kat 'APC' Smith, Thwomp, Waseemq1235 add: Desk bell for cargo, medbay, brig, and AI reception. soundadd: Desk bell sound effect. /:cl: <!-- Both :cl:'s are required for the changelog to work! --> --------- Co-authored-by: SabreML <[email protected]>
About the pull request
Using my maintainer privilege to add this small feature during the freeze. A desk bell.
Wrench to secure it and use it.
Bell can break at a 1% chance for every 100 rings. In which case a screwdriver will fix it.
Credit:
Modified code and desk_bell.ogg from Paradise SS13
Sprite from Kat 'APC' Smith - darklordcabbage on discord.
Animated sprite from Thwomp
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 Birdtalon, Kat 'APC' Smith, Thwomp
add: Desk bell for cargo and medbay.
soundadd: Desk bell sound effect.
/:cl: